feat(api): make Nomad node pool configurable#2368
Open
chencjcj wants to merge 1 commit intoe2b-dev:mainfrom
Open
feat(api): make Nomad node pool configurable#2368chencjcj wants to merge 1 commit intoe2b-dev:mainfrom
chencjcj wants to merge 1 commit intoe2b-dev:mainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Nomad node pool name is currently hardcoded as
"default"in the API's orchestrator client . This PR makes it configurable via theNOMAD_NODE_POOLenvironment variable, enabling deployments that use custom Nomad node pools.Changes
NomadNodePoolconfig field (NOMAD_NODE_POOLenv var, defaults to"default")"default"pool filter inlistNomadNodeswith the configurable valueNOMAD_NODE_POOLfrom Terraform (var.orchestrator_node_pool) to the API job in both GCP and AWS providers