You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Touches template deletion and build-cancellation flow, plus changes the DeleteTemplate query return shape; mistakes could leave builds running or cause partial cleanup/cancellation failures.
Overview
Template deletion now also cancels any in-progress builds for the deleted template by extending DeleteTemplate to return both alias keys and active build metadata (build/node/cluster) and invoking orchestrator build deletion with a timeout. Snapshot cleanup and cache invalidation were updated to handle the new DeleteTemplate return type, and the unused DeleteActiveTemplateBuild SQL/query was removed with tests adjusted accordingly.
Reviewed by Cursor Bugbot for commit c3fbe3a. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel active template builds when deleting template