[fix/test][web-sample] Lombok annotationProcessorPaths 수정 및 SampleMapper CRUD 단위 테스트 추가#31
Closed
dasomel wants to merge 1 commit into
Closed
Conversation
…CRUD 단위 테스트 추가 Lombok @Getter/@Setter 적용 후 maven-compiler-plugin에 annotationProcessorPaths가 누락되어 컴파일 오류가 발생하는 문제를 수정한다. skipTests 설정을 property로 외부화하여 CLI에서 -DskipTests=false로 테스트 실행 가능하게 한다. SampleMapper의 selectSample, updateSample, deleteSample, selectSampleList/selectSampleListTotCnt 4가지 DAO 메서드에 대한 단위 테스트를 추가한다.
Contributor
|
표준프레임워크에 대한 지속적인 참여에 대단히 감사드립니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lombok
@Getter/@Setter도입(#26) 이후maven-compiler-plugin에annotationProcessorPaths설정이 누락되어 로컬 빌드가 실패하는 문제를 수정하고,SampleMapperDAO의 나머지 CRUD 메서드에 대한 단위 테스트를 추가합니다.변경 내용
pom.xml
maven-compiler-plugin에annotationProcessorPaths추가 — Lombok annotation processor가 올바르게 등록되어@Getter/@Setter생성 코드를 인식skipTests설정을 property로 외부화(<skipTests>${skipTests}</skipTests>) — CLI에서-DskipTests=false로 테스트 실행 가능SampleMapper 단위 테스트 4개 신규 추가
SampleMapperTestSelectSampleTest—selectSample단건 조회 검증SampleMapperTestUpdateSampleTest—updateSample수정 후 재조회 검증SampleMapperTestDeleteSampleTest—deleteSample삭제 후 null 반환 검증SampleMapperTestSelectSampleListTest—selectSampleList/selectSampleListTotCnt목록 조회 및 전체 건수 검증기존
SampleMapperTestInsertSampleTest와 동일한 패턴(given-when-then,EgovTestAbstractSpring, HSQLDB 인메모리 DB,@Transactional롤백)을 따릅니다.테스트 확인
체크리스트