[24451] Add Topic-Name Profile Lookup for Endpoint Creation by ZakariaTalbi · Pull Request #184 · eProsima/DDS-Pipe

ZakariaTalbi · 2026-05-13T10:13:45Z

Included support for topic-name profile lookup by adding create_datawriter_with_profile() as the default path in CommonWriter.cpp, with fallback to create_datawriter() when needed.

Added a new test, writer_topic_profile_lookup(), in ParticipantsCreationgTest.cpp to validate the feature, and registered it in CMakeLists.txt.

codecov-commenter · 2026-05-13T10:26:21Z

Codecov Report

❌ Patch coverage is 61.84211% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.57%. Comparing base (2d1ed3f) to head (503947b).

Files with missing lines	Patch %	Lines
ddspipe_yaml/src/cpp/YamlReader_participants.cpp	0.00%	9 Missing ⚠️
...e_participants/src/cpp/reader/dds/CommonReader.cpp	72.72%	1 Missing and 5 partials ⚠️
...e_participants/src/cpp/writer/dds/CommonWriter.cpp	81.81%	1 Missing and 3 partials ⚠️
...ants/src/cpp/participant/dds/CommonParticipant.cpp	57.14%	0 Missing and 3 partials ⚠️
...ticipants/src/cpp/writer/dds/QoSSpecificWriter.cpp	0.00%	3 Missing ⚠️
...participants/participant/dds/CommonParticipant.hpp	0.00%	2 Missing ⚠️
...pe_participants/src/cpp/writer/dds/MultiWriter.cpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   36.09%   36.57%   +0.48%     
==========================================
  Files         174      159      -15     
  Lines       12329     7559    -4770     
  Branches     5634     3002    -2632     
==========================================
- Hits         4450     2765    -1685     
+ Misses       5023     3335    -1688     
+ Partials     2856     1459    -1397

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

juanlofer-eprosima

Good job! 🥇 We mostly need to decide if XML > YAML or the other way around, we could even add a configuration option to the YAML so we can keep both possibilities and let the user decide.

It is pending to update the documentation of tools using DDS-Pipe.

juanlofer-eprosima · 2026-05-22T07:32:54Z

+    fastdds::dds::ReturnCode_t ret_xml_qos = dds_subscriber_->get_datareader_qos_from_profile(topic_name, qos);
+
+    if (ret_xml_qos != fastdds::dds::RETCODE_OK)


Suggested change

fastdds::dds::ReturnCode_t ret_xml_qos = dds_subscriber_->get_datareader_qos_from_profile(topic_name, qos);

if (ret_xml_qos != fastdds::dds::RETCODE_OK)

if (fastdds::dds::RETCODE_OK != dds_subscriber_->get_datareader_qos_from_profile(topic_name, qos))

I am now thinking maybe we should already return here if the profile is found. There might be scenarios in which a user wants to force a specific durability/reliability or history QoS, and if we override with the YAML configuration values, we would be forcing the user to configure through both XML and YAML. However, it would be beneficial to automatically add QoS such as expect_inline_qos for keyed topics.

juanlofer-eprosima · 2026-05-22T07:33:45Z

 {
-    fastdds::dds::DataWriterQos qos = dds_publisher_->get_default_datawriter_qos();
+    fastdds::dds::DataWriterQos qos;
+    fastdds::dds::ReturnCode_t ret_xml_qos = dds_publisher_->get_datawriter_qos_from_profile(topic_name, qos);


Same suggestion as in reader.

juanlofer-eprosima · 2026-05-22T07:59:45Z

+
+    if (ret_xml_qos != fastdds::dds::RETCODE_OK)
+    {
+        qos = dds_publisher_->get_default_datawriter_qos();


Same comment as in the reader, in this case writer_data_lifecycle and deadline might need special treatment. Note that in this case overriding the deadline via YAML is not possible.

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

juanlofer-eprosima · 2026-06-04T09:53:42Z

    core::types::IgnoreParticipantFlags ignore_participant_flags {core::types::IgnoreParticipantFlags::no_filter};
+
+    // XML override
+    bool xml_override {false};


Please move this to XMLParticipantConfiguration, then you can get its value through a CommonParticipant virtual method overriden in the XML one.

And I suggest changing its name, maybe something like "endpoint_qos_extraction" or "endpoint_qos_derivation", and make it an enumeration so it's more flexible in case we need to add more modes (its values could be "XML_OVERRIDABLE", "XML_STANDALONE", for example, not feeling inspired).

juanlofer-eprosima · 2026-06-04T09:55:42Z

+    bool xml_profile_found =
+            (fastdds::dds::RETCODE_OK == dds_subscriber_->get_datareader_qos_from_profile(topic_name, qos));
+
+    if (!xml_profile_found || xml_override_)


Please change it so that the default behaviour is to enforce YAML/discovery configuration.

juanlofer-eprosima · 2026-06-04T10:26:30Z

    fastdds::dds::DataReaderQos
-    reckon_reader_qos_() const;
+    reckon_reader_qos_(
+            const std::string& topic_name) const;


Suggested change

const std::string& topic_name) const;

const std::string& profile_name) const;

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

ZakariaTalbi temporarily deployed to codecov May 13, 2026 10:13 — with GitHub Actions Inactive

ZakariaTalbi requested a review from richiprosima May 13, 2026 10:14

Tests for Topic-Name Profile Lookup

2f3beaf

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

ZakariaTalbi force-pushed the feature/topic-name-profile-lookup branch from ad3731a to 2d92e48 Compare May 14, 2026 12:52

ZakariaTalbi temporarily deployed to codecov May 14, 2026 12:52 — with GitHub Actions Inactive

ZakariaTalbi requested review from richiprosima and removed request for richiprosima May 14, 2026 12:52

ZakariaTalbi added 2 commits May 19, 2026 09:30

Corrected tests for Profile Lookup

1b1889e

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

Features for Topic-Name Profile Lookup

696de7d

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

ZakariaTalbi force-pushed the feature/topic-name-profile-lookup branch from 2d92e48 to 696de7d Compare May 19, 2026 07:33

ZakariaTalbi temporarily deployed to codecov May 19, 2026 07:33 — with GitHub Actions Inactive

juanlofer-eprosima requested changes May 22, 2026

View reviewed changes

juanlofer-eprosima changed the title ~~Feature/topic name profile lookup~~ [24451] Add Topic-Name Profile Lookup for Endpoint Creation May 22, 2026

Corrected Reader/Writer features for Topic Profile Lookup

3d75d41

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

ZakariaTalbi temporarily deployed to codecov May 22, 2026 09:07 — with GitHub Actions Inactive

ZakariaTalbi added 2 commits May 26, 2026 10:57

XML override test

1c04583

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

XML override feature

356e74d

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

ZakariaTalbi temporarily deployed to codecov May 26, 2026 08:59 — with GitHub Actions Inactive

juanlofer-eprosima requested changes Jun 4, 2026

View reviewed changes

ZakariaTalbi added 2 commits June 4, 2026 15:44

Applied Suggestions for Topic Profile lookup on tests

07c0a30

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

Applied Suggestions for Topic Profile lookup for feature

503947b

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

ZakariaTalbi temporarily deployed to codecov June 4, 2026 13:45 — with GitHub Actions Inactive

Danipiza self-requested a review June 18, 2026 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[24451] Add Topic-Name Profile Lookup for Endpoint Creation#184

[24451] Add Topic-Name Profile Lookup for Endpoint Creation#184
ZakariaTalbi wants to merge 8 commits into
mainfrom
feature/topic-name-profile-lookup

ZakariaTalbi commented May 13, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented May 13, 2026 •

edited

Loading

Uh oh!

juanlofer-eprosima left a comment •

edited

Loading

Uh oh!

juanlofer-eprosima May 22, 2026

Uh oh!

juanlofer-eprosima May 22, 2026

Uh oh!

juanlofer-eprosima May 22, 2026

Uh oh!

juanlofer-eprosima May 22, 2026

Uh oh!

juanlofer-eprosima Jun 4, 2026

Uh oh!

juanlofer-eprosima Jun 4, 2026

Uh oh!

juanlofer-eprosima Jun 4, 2026

Uh oh!

juanlofer-eprosima Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		fastdds::dds::ReturnCode_t ret_xml_qos = dds_subscriber_->get_datareader_qos_from_profile(topic_name, qos);

		if (ret_xml_qos != fastdds::dds::RETCODE_OK)

	const std::string& topic_name) const;
	const std::string& profile_name) const;

Conversation

ZakariaTalbi commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

juanlofer-eprosima left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ZakariaTalbi commented May 13, 2026 •

edited

Loading

codecov-commenter commented May 13, 2026 •

edited

Loading

juanlofer-eprosima left a comment •

edited

Loading