Skip to content

[25442] Make skip-ci label report required statuses as pass#581

Merged
MiguelCompany merged 1 commit into
masterfrom
ci/25442
Jun 23, 2026
Merged

[25442] Make skip-ci label report required statuses as pass#581
MiguelCompany merged 1 commit into
masterfrom
ci/25442

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Move conditionals in the CI from jobs to steps, so the options in matrix are always considered, and thus all the corresponding statuses are shown as passed when the skip-ci label is present.

@Mergifyio backport 4.0.x 3.3.x 2.1.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v4.3.1 milestone Jun 22, 2026
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jun 22, 2026
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 22, 2026 14:28
@MiguelCompany MiguelCompany added no-test and removed skip-ci Automatically pass CI labels Jun 22, 2026
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 22, 2026 14:30
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 22, 2026
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 22, 2026 14:44

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@MiguelCompany MiguelCompany merged commit 724b278 into master Jun 23, 2026
6 checks passed
@MiguelCompany MiguelCompany deleted the ci/25442 branch June 23, 2026 12:05
@MiguelCompany

Copy link
Copy Markdown
Member Author

@Mergifyio backport 4.0.x 3.3.x 2.1.x

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

backport 4.0.x 3.3.x 2.1.x

✅ Backports have been created

Details

Cherry-pick of 724b278 has failed:

On branch mergify/bp/4.0.x/pr-581
Your branch is up to date with 'origin/4.0.x'.

You are currently cherry-picking commit 724b278.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/reusable-ubuntu-ci.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 724b278 has failed:

On branch mergify/bp/3.3.x/pr-581
Your branch is up to date with 'origin/3.3.x'.

You are currently cherry-picking commit 724b278.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/reusable-ubuntu-ci.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 724b278 has failed:

On branch mergify/bp/2.1.x/pr-581
Your branch is up to date with 'origin/2.1.x'.

You are currently cherry-picking commit 724b278.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/reusable-ubuntu-ci.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

MiguelCompany added a commit that referenced this pull request Jun 23, 2026
* Make `skip-ci` label report required statuses as pass (#581)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 724b278)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 24, 2026
…586)

* Make `skip-ci` label report required statuses as pass (#581) (#582)

* Make `skip-ci` label report required statuses as pass (#581)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 724b278)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6380762)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 24, 2026
* Make `skip-ci` label report required statuses as pass (#581)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 724b278)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 24, 2026
…586)

* Make `skip-ci` label report required statuses as pass (#581) (#582)

* Make `skip-ci` label report required statuses as pass (#581)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 724b278)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6380762)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 24, 2026
* Make `skip-ci` label report required statuses as pass (#581)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 724b278)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6380762)
MiguelCompany added a commit that referenced this pull request Jun 24, 2026
…586)

* Make `skip-ci` label report required statuses as pass (#581) (#582)

* Make `skip-ci` label report required statuses as pass (#581)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 724b278)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6380762)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 24, 2026
…585)

* Make `skip-ci` label report required statuses as pass (#581)


(cherry picked from commit 724b278)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Fix conflicts



---------



(cherry picked from commit 6380762)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running no-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants