Skip to content

[#24288] Clarify default empty Partition behavior in Partition QoS (backport #1237)#1245

Merged
MiguelCompany merged 1 commit into
3.4.xfrom
mergify/bp/3.4.x/pr-1237
Jun 16, 2026
Merged

[#24288] Clarify default empty Partition behavior in Partition QoS (backport #1237)#1245
MiguelCompany merged 1 commit into
3.4.xfrom
mergify/bp/3.4.x/pr-1237

Conversation

@mergify

@mergify mergify Bot commented Mar 30, 2026 •
edited by MiguelCompany
Loading

Copy link
Copy Markdown

Description

This PR clarifies how the default partition works in DDS Partition QoS.

Changes:

  • Explicitly states that the default partition name is the empty string ("").
  • Clarifies that {} is equivalent to {""}.
  • Keeps tables aligned with the empty/default partition semantics.

PR FastDDS 6007

@Mergifyio backport 2.14.x 3.2.x 3.4.x 3.5.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • The Pro version badge has been added if the documented feature is exclusive to Fast DDS Pro.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.
This is an automatic backport of pull request #1237 done by [Mergify](https://mergify.com).

@mergify mergify Bot mentioned this pull request Mar 30, 2026
Merged
9 tasks
@Danipiza Danipiza force-pushed the mergify/bp/3.4.x/pr-1237 branch from 5137d1d to 0dc604d Compare March 30, 2026 12:56
@Danipiza Danipiza requested a review from zesk1999 March 30, 2026 12:57
@Danipiza Danipiza requested review from Danipiza and removed request for zesk1999 March 31, 2026 08:53
@Danipiza Danipiza force-pushed the mergify/bp/3.4.x/pr-1237 branch from 0dc604d to e7d10cd Compare March 31, 2026 08:55
@Danipiza Danipiza requested review from Danipiza and removed request for Danipiza March 31, 2026 08:56
Danipiza
Danipiza approved these changes Mar 31, 2026
View reviewed changes

@Danipiza Danipiza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany added this to the v3.4.3 milestone Jun 16, 2026
@MiguelCompany

MiguelCompany commented Jun 16, 2026

Copy link
Copy Markdown
Member

@Mergifyio rebase

@Danipiza @MiguelCompany
Clarify default empty Partition behavior in Partition QoS (#1237)
5bae86e 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown
Author

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany force-pushed the mergify/bp/3.4.x/pr-1237 branch from e7d10cd to 5bae86e Compare June 16, 2026 11:02
@MiguelCompany MiguelCompany self-requested a review June 16, 2026 11:05
@MiguelCompany MiguelCompany merged commit f80e233 into 3.4.x Jun 16, 2026
5 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.4.x/pr-1237 branch June 16, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes
@Danipiza Danipiza Danipiza approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v3.4.3 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @Danipiza