[25442] Make skip-ci label report required statuses as pass#6442
Conversation
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
cferreiragonz
left a comment
There was a problem hiding this comment.
Shouldn't we apply the same logic to jobs of reusable-sanitizers-ci.yml? Right now, if-conditions are linked to each job, not steps. So jobs will be completely skipped.
Since they don't have a matrix, this is not necessary. Changing it would make it be reported as successful instead of skipped. |
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
|
Tick the box to add this pull request to the merge queue (same as
|
|
@Mergifyio backport 3.2.x 2.14.x |
✅ Backports have been createdDetails
Cherry-pick of 2ff2b60 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 2ff2b60 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Description
@Mergifyio backport 3.2.x 2.14.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist