[#24371] Render stderr output in red in the Textual console#19
Open
Danipiza wants to merge 2 commits into
Open
[#24371] Render stderr output in red in the Textual console#19Danipiza wants to merge 2 commits into
Danipiza wants to merge 2 commits into
Conversation
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
cferreiragonz
requested changes
May 12, 2026
|
|
||
| def __init__(self, app, stream_name: str = "stdout"): | ||
| self.app = app | ||
| self.stream_name = stream_name |
Contributor
There was a problem hiding this comment.
Suggested change
| self.stream_name = stream_name | |
| self.color = "red" if stream_name == "stderr" else "" |
Comment on lines
+62
to
+63
| color = "red" if self.stream_name == "stderr" else "" | ||
| self.app.call_from_thread(self.app.add_line, data, color) |
Contributor
There was a problem hiding this comment.
Suggested change
| color = "red" if self.stream_name == "stderr" else "" | |
| self.app.call_from_thread(self.app.add_line, data, color) | |
| self.app.call_from_thread(self.app.add_line, data, self.color) |
AI suggested to also pass self.app.call_from_thread(self.app.add_line, data, self.color, True) here to set subprocess_flag to True.
| "textual-serve==1.1.3", | ||
| "typeguard==2.13", | ||
| "pyperclip==1.11.0", | ||
| "torch==2.10.0", |
Contributor
There was a problem hiding this comment.
Suggested change
| "torch==2.10.0", |
I would delete this. I could not find any issue with our dependencies testing locally. I believe issues with torch versions are more related to specific Nvidia Drivers versions rather than our deps, hence, leaving pip to automatically select the versions seems like the more appropriate and suitable way to go in order to be compatible with as much devices as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
