Get attribute values before type casting to fix enum attributes insert#3
Merged
Conversation
Member
|
Can you make a spec to verify usage with enums? @carlos-musetti |
3ba4e00 to
014572a
Compare
There was a problem hiding this comment.
Pull request overview
Fixes staging inserts for ActiveRecord enum-backed columns by normalizing AR records into “database-ready” attribute values (instead of enum labels), and adds regression coverage across supported DB adapters.
Changes:
- Add regression specs ensuring enum attributes are staged as underlying DB integers (AR objects, relations, and plain hashes).
- Update
StagingTable::Sessionrecord normalization to preferattributes_for_database/read_attribute_for_database.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
spec/staging_table/enum_attributes_spec.rb |
Adds multi-adapter regression tests for enum value normalization through staging + transfer. |
lib/staging_table/session.rb |
Changes normalization logic to extract database values for AR records (aimed at fixing enum inserts). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
014572a to
da72212
Compare
da72212 to
115d54e
Compare
sncalvo
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a model with an enum.
When trying to insert records into this model, the
INSERT INTOtuple would have the cast value (i.e.rawinstead of 0), triggering an error sincepostgresql` expected the value before casting.