You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the "overclock when busy" option is enabled with TI-89 family calculators, using the arrow keys in menus will cause skipping. This appears to happen because turbo kicks in too soon, resulting in the arrow keys triggering the calculator's autorepeat. This seems to be fixed simply by waiting 2 frames before starting turbo. Menu scrolling usually seems to complete in a single frame.
@eanema Do you have any objections to simply removing the screen update thread? As far as I can tell, there is no performance penalty from running screen refresh within the emulation thread. correction: yes there is. Merging the screen thread also seems to reduce flickering and other artifacts. I assume they were originally separate threads since phones 10 years ago were slow.
The root cause of the menu skipping issue is that isBusy is only updated from the screen thread, but the screen thread runs at a constant rate (SCREEN_LOOP_SLEEP) irrespective of whether the emulation thread is turboing. As such, if the emulation thread begins turboing, it won't stop until the screen thread next wakes up, even if the busy status was cleared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the "overclock when busy" option is enabled with TI-89 family calculators, using the arrow keys in menus will cause skipping. This appears to happen because turbo kicks in too soon, resulting in the arrow keys triggering the calculator's autorepeat. This seems to be fixed simply by waiting 2 frames before starting turbo. Menu scrolling usually seems to complete in a single frame.
Also, thanks for reviving the project.