Fix keyword rendering for DefinedTerm objects#219
Open
ywkim312 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix keyword rendering for DefinedTerm objects
Fixes #216
Changes
nameproperty fromDefinedTermobjects in keywords/variables on dataset pagesDefinedTermobjectsTesting
Start client with deepoceans config:
PC
Ubuntu
Search for "BODC":
Verify dataset pages:
variableMeasuredfields display correctlyTest with the specific BODC dataset from issue BODC bad rendering Keywords that are list of DefinedTerm #216:
I pushed the new test config file named config_qlever_test.yaml for this test
http://localhost:5173/#/dataset/urn:gleaner.io:eco:bodc:data:99c10d8deeeb174480dce0de1a75ac21b4f3860a"[object Object], [object Object]..."(17 times)Verification
Fix verified: Tested with the specific BODC dataset from issue #216. All 17 keywords from DefinedTerm objects now display correctly as clickable links instead of "[object Object]" text. The fix successfully extracts the
nameproperty from DefinedTerm objects and preserves URLs for rendering as links.Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.
Type of changes
Please select a relevant option:
Checklist:
Please select all applicable options: