Add Search2 pagination and enable browse-all results for empty keyword#268
Open
ywkim312 wants to merge 3 commits into
Open
Add Search2 pagination and enable browse-all results for empty keyword#268ywkim312 wants to merge 3 commits into
ywkim312 wants to merge 3 commits into
Conversation
…sistent reset-to-page-1 behavior
…ing initial query state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #230 #266
Description
Summary
pageandlimitquery paramsUser-facing behavior changes
X / pagecontrols.Technical notes
FilterStateManager+useSearch.Showing 101-150 of N results).Files changed
client/src/services/FilterStateManager.jsclient/src/composables/useSearch.jsclient/src/components/facetsearch/ResultHeader2.vueclient/src/components/facetsearch/Search2.vueTest plan
#/Search2?q=waterand verify pagination controls appear.pageand results update accordingly.limitupdates and page resets to 1.#/Search2(empty keyword) and verify results are shown (not blank/no-results).#/Search2?q=water&page=3&limit=50) and verify state and results are restored.