You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
UPDATE: this is good to go for a review. all functions are now covered via tests and i did some cleanup on the test suite itself and added lots of notes about process. There are a few fixtures that i think i can simplify by creating a fixture helper function and then separate small fixtures.
i will come back and work on that later maybe after the review even depending on timing. but this is ready for a solid look!
I did a lot of docstring updates in the other pr here Tests for git / github module - adventures in patching and mocking #445 that i need to move over as they are good doc updates. Make sure this happens across all modules. I suppose it also could just be a pr outside of the tests to keep things simple and that would be easy to merge.
UPDATE: i believe that i can globally patch if i move to an object oriented test suite -
Merging #459 (8c3321b) into main (54f4b3c) will increase coverage by 8.74%.
The diff coverage is 100.00%.
❗ Current head 8c3321b differs from pull request most recent head c380810. Consider uploading reports for the commit c380810 to get more accurate results
ok team! we are at 100% coverage for the auth module. I had done most of the work. there is a failure happening on one of the tests that i am not sure relates to this but i'll look into it as it's come up twice now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE: this is good to go for a review. all functions are now covered via tests and i did some cleanup on the test suite itself and added lots of notes about process. There are a few fixtures that i think i can simplify by creating a fixture helper function and then separate small fixtures.
i will come back and work on that later maybe after the review even depending on timing. but this is ready for a solid look!
this will address some of #361 #194
TODO:
UPDATE: i believe that i can globally patch if i move to an object oriented test suite -