Fix non-interactive cmd.sh#5187
Open
Flamefire wants to merge 2 commits into
Open
Conversation
When running `bash -i` with `-c` it might have unintended side effects, like modifying the parent processes state. This manifests e.g. in the tests: `python -m test.framework.suite test_run_shell_cmd_basic` causes the process to go to background and stall until typing `fg` on the 2nd invocation of `run_shell_cmd` with `cmd.sh -c ...` Using `BASH_ENV` for the non-interactive use avoids this while still sourcing the env file. To detect that the presence of any argument to `cmd.sh` is used as for interactive usage none would be present.
Otherwise the space won't be printed when it is empty and the regex fails.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
bash -iwith-cit might have unintended side effects, like modifying the parent processes state.This manifests e.g. in the tests:
python -m test.framework.suite test_run_shell_cmd_basiccauses the process to go to background and stall until typingfgon the 2nd invocation ofrun_shell_cmdwithcmd.sh -c ...Using
BASH_ENVfor the non-interactive use avoids this while still sourcing the env file.To detect that the presence of any argument to
cmd.shis used as for interactive usage none would be present.See https://www.gnu.org/software/bash/manual/html_node/Bash-Startup-Files.html