Cleanup duplication in handle_include_easyblocks_from#5194
Open
Flamefire wants to merge 1 commit into
Open
Conversation
Move the logging from each option branch to a common function. Ensure `included_easyblocks` is defined before the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen the linter warning that
included_easyblocksmay be used before assignment in thecheck_included_multiplefunction.So ensure
included_easyblocksis defined before the function.Also the whole logging and checking code is duplicated in each branch (for the CLI options),
so move the logging from each option branch to a common function.
This can use the function that checks for duplicates as both are just logging the inclusion (the warning is also just a "log")
This makes the whole handling uniform: