Skip to content

Use sendNow for test notifications; update label #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
venelinkochev merged 1 commit into from
Apr 24, 2026
Merged

Use sendNow for test notifications; update label #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/Livewire/Settings/Notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,10 @@ public function sendTest(int $channelId): void
$monitor->id = 0;
$monitor->last_checked_at = now();

NotificationFacade::send([$channel], new MonitorRecovered($monitor));
// sendNow() bypasses the queue — a queued test would try to
// re-hydrate this transient Monitor via findOrFail($id) on the worker
// and silently fail, leaving the user wondering why nothing arrived.
NotificationFacade::sendNow([$channel], new MonitorRecovered($monitor));

$this->dispatch('notifications-test-sent', channelId: $channel->id);
}
Expand Down
2 changes: 1 addition & 1 deletion resources/views/livewire/settings/notifications.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class="btn btn-ghost btn-sm">
x-on:notifications-test-sent.window="if ($event.detail.channelId === {{ $channel->id }}) { sent = true; setTimeout(() => sent = false, 2500); }"
class="flex items-center gap-2">
<span x-show="sent" x-transition.opacity class="text-sm text-success" style="display:none">
{{ __('Test queued') }}
{{ __('Test sent') }}
</span>
<button type="button"
x-on:click="sending = true; $wire.sendTest({{ $channel->id }}).finally(() => sending = false)"
Expand Down
Loading