Add ICMP check type to monitors#37
Merged
Merged
Conversation
Introduce an ICMP (ping) check type and wire it through the app: add a CheckType enum, a string check_type column (default 'http') via migration, and cast Monitor.check_type to the enum. Update Livewire Create/Edit components and views to expose a Check Type radio, adjust URL/Host input, add validation (including a regex for host/IP without scheme/path) and custom error message, and persist check_type. Ensure probe dispatching prefixes icmp:// for ICMP checks in CheckDispatcher. Add factory default and icmp state helper, update index/show badges, add feature and unit tests for ICMP behavior, and include a README screenshot image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an ICMP (ping) check type and wire it through the app: add a CheckType enum, a string check_type column (default 'http') via migration, and cast Monitor.check_type to the enum. Update Livewire Create/Edit components and views to expose a Check Type radio, adjust URL/Host input, add validation (including a regex for host/IP without scheme/path) and custom error message, and persist check_type. Ensure probe dispatching prefixes icmp:// for ICMP checks in CheckDispatcher. Add factory default and icmp state helper, update index/show badges, add feature and unit tests for ICMP behavior, and include a README screenshot image.