fix test and generation of schema#220
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the EasyP config schema generation flow so generate.plugins[].opts can describe non-string scalar values, and adjusts tests/artifacts around that behavior in the schema/MCP layer.
Changes:
- Expanded the generated JSON schema for plugin options to allow
numberandbooleanvalues, both as scalars and inside arrays. - Regenerated the checked-in schema artifacts and added MCP/schema tests covering the new shape.
- Updated config/test fixtures and one managed-mode test expectation to align with current behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
schemas/easyp-config.schema.json |
Regenerated latest JSON schema artifact with broader plugin option value types. |
schemas/easyp-config-v1.schema.json |
Regenerated versioned JSON schema artifact to match the schema model changes. |
mcp/easypconfig/schema_model.go |
Source-of-truth schema model now allows numeric/boolean plugin option values and arrays containing them. |
mcp/easypconfig/easypconfig_test.go |
Adds schema-path assertions and helpers for the updated plugin options schema. |
internal/core/generate_managed_mode_test.go |
Adjusts mock expectations for current lockfile interactions in managed-mode generation tests. |
internal/config/validate_raw_test.go |
Extends raw config validation fixture to include boolean and numeric plugin option scalars. |
go.mod |
Adds formatting-only whitespace change. |
easyp.yaml |
Updates the repo’s sample/default config by adding a Python plugin entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 22 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.