Skip to content

fix issue 222: https://github.com/easyp-tech/easyp/issues/222#223

Merged
Yakwilik merged 1 commit into
mainfrom
fix/issues/222
May 14, 2026
Merged

fix issue 222: https://github.com/easyp-tech/easyp/issues/222#223
Yakwilik merged 1 commit into
mainfrom
fix/issues/222

Conversation

@Yakwilik
Copy link
Copy Markdown
Member

@Yakwilik Yakwilik commented May 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 6, 2026 20:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the module installation flow in internal/adapters/storage to address issue #222 by extracting archives into a temporary location and then constructing the final install tree via a custom path-rewriting/copy step (including special handling for symlinks).

Changes:

  • Extract archives into a temporary directory instead of directly into the install directory.
  • Build a rewritten install tree (copy files + rewrite symlinks) into a temp install directory.
  • Replace the existing install directory with the newly built tree and hash the final content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/adapters/storage/install.go Outdated
Comment thread internal/adapters/storage/install.go Outdated
Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install.go Outdated
Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install.go Outdated
Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install.go
@Yakwilik Yakwilik force-pushed the fix/issues/222 branch 2 times, most recently from 01f7d5d to f53ffa2 Compare May 6, 2026 21:02
@Yakwilik Yakwilik requested a review from Copilot May 6, 2026 21:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread internal/adapters/storage/install.go Outdated
Comment thread internal/adapters/storage/install.go Outdated
Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install_test.go Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install.go Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install.go Outdated
Comment thread internal/adapters/storage/install.go
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install.go
Comment thread internal/adapters/storage/install_test.go
@Yakwilik Yakwilik merged commit 77bd3b1 into main May 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants