Add testcase that tickles bug in history#3082
Closed
tobias- wants to merge 2 commits into
Closed
Conversation
…_historied_historyless_historied Conflicts: ebean-test/src/test/java/org/tests/model/history/HistoryOneToOne.java ebean-test/src/test/java/org/tests/model/history/HistorylessOneToOne.java
tobias-
force-pushed
the
findVersions_over_historied_historyless_historied
branch
from
ce97fe4 to
47b5ed1
Compare
rob-bygrave
added a commit
that referenced
this pull request
Jun 30, 2026
…er history table Bug (#3083): findVersions() on a @history root that joins to another @history entity bound the joined table's effective-date predicate with a null as-of timestamp → systime <@ null (Postgres) / sys_period_start <= null (H2) → zero rows. Fix (CQueryPredicates.bind(), +6 lines): when the as-of is null but there are history-view join predicates to bind (asOfTableCount > 0 — only ever true for findVersions/findVersionsBetween), default to the current timestamp. Semantics: all versions of the root, joined to related @history entities as they are now. The root table is untouched (still returns all versions). Test ported from #3082 : - New HistoryManyToOne entity (@history + @softdelete) — kept lean, dropped the PR's unneeded @onetomany - HistorylessOneToOne gains @manytoone HistoryManyToOne - New testVersionsWithHistoryOverHistoryless() — replaced the PR's always-failing placeholder (assertSql(...).contains("this does not exist")) with real assertions: count == 1 and SQL contains no asOf null bind - Left the existing @OnetoOne unchanged (the PR's optional = false tweak to the shared model wasn't needed)
Member
|
Replaced by 443b68a fixed in version 18.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR demonstrates a bug in history where if you do
findVersions()on a history object that references a non-versioned and then a versioned object again, asystime <@ nullwill be added to the query (postgres) which will of course always fail.This proves the bug reported as #3083