Merged
Conversation
…to show the current issue in a better way
hajimehoshi
reviewed
Jul 2, 2025
Member
hajimehoshi
left a comment
There was a problem hiding this comment.
Let's add a dropdown to example/gallery
hajimehoshi
reviewed
Jul 2, 2025
Contributor
Author
|
I have made the changes, removed the Dropdown type, renamed that variable and put one example of the dropdown into the gallery, into a window |
hajimehoshi
reviewed
Jul 2, 2025
hajimehoshi
reviewed
Jul 3, 2025
hajimehoshi
reviewed
Jul 3, 2025
Member
hajimehoshi
left a comment
There was a problem hiding this comment.
The code seems generally good.
Removed some obvious comments, keeping only the specific ones about the dropdowns removed isOpen variable that was used only once
Contributor
Author
|
I corrected wrong licence Now the code seems pretty clean |
hajimehoshi
reviewed
Jul 3, 2025
hajimehoshi
reviewed
Jul 3, 2025
hajimehoshi
reviewed
Jul 3, 2025
hajimehoshi
approved these changes
Jul 3, 2025
hajimehoshi
requested changes
Jul 3, 2025
Member
hajimehoshi
left a comment
There was a problem hiding this comment.
(Sorry I've not approved yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a dropdown menu for debugui.
It allows listing selectable items, but there's still an issue: widgets behind the dropdown remain interactable, even when the dropdown is open and overlapping them.
Usage is just like the other widgets