Keyboard support for Cardputer ADV#205
Open
carnitashredder wants to merge 1 commit intoecho-lalia:mainfrom
Open
Keyboard support for Cardputer ADV#205carnitashredder wants to merge 1 commit intoecho-lalia:mainfrom
carnitashredder wants to merge 1 commit intoecho-lalia:mainfrom
Conversation
Owner
|
Thanks for your contribution! I don't see any issues with this on first glance, but I can't properly test your changes as I don't have the device myself. If/when other community members can confirm that this can be built/compiled successfully, and it works as expected on the Cardputer ADV, then I'll merge your changes :) |
echo-lalia
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cardputer ADV folder in devices. I have tested on my device with a plain MicroPython install. For testing I simply placed the TCA8418 in the userinput folder. As well as replacing the _keys file with this updated version. This is my first PR, I apologize in advance if there are issues.