Small UI improvements and accessibility fixes#1504
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1504 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1504", name: che-dashboard}]}}]" |
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
- handlebars: 4.7.8 -> 4.7.9 - yaml: 2.8.2 -> 2.8.3 - picomatch: 2.3.1 -> 2.3.2 - fastify: 5.7.4 -> 5.8.4 - undici: 7.22.0 -> 7.24.6 - svgo: 3.0.2 -> 3.3.3 Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Node.js 18 lacks the File global required by undici >=7.22. Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
…nd BulkSelector - Add Enter key toggle support to TemporaryStorageSwitch and CreateNewIfExistSwitch - Add icon hover color via PatternFly CSS tokens - Fix BulkSelector onSelect type to accept keyboard events Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Remove hardcoded black/white backgrounds from ErrorReporter; use PatternFly's default page background. Center content via flexbox on the PageSection instead of a Stack. Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Replace Page wrapper in ErrorReporter with a position:fixed div so it always covers the full viewport, including any sidebar rendered by PatternFly's internal sidebar state management. Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
…port Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
…ter-info on error Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
…ainer Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
…ction buttons Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
… contrast issues Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Remove custom onKeyDown from SelectOption — it caused a double-call to onSelect (once from our handler, once from PF6's Enter→click→onChange path), resulting in add→remove with net zero change. PF6 Menu handles Enter natively via document.activeElement.click() on the focused label. Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
The gitbranches API calls git ls-remote in the backend process. Without git installed in the runtime container, this fails with spawn git ENOENT (500 Internal Server Error). Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
The gitbranches API calls git ls-remote in the backend process. Add git to skaffold.Dockerfile (Alpine-based dev image) and update copyright year to 2026. Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
- Update 3 failing snapshot tests after ErrorReporter and Toolbar changes - Fix "Logout" → "Sign out" label in IssueComponent - Set MIT license for fastify@5.8.4 in .deps/prod.md - Add flatted@3.4.2, tar@7.5.11, @types/stream-buffers@3.0.8 to .deps/EXCLUDED/dev.md - Add fastify@5.8.4, undici@7.24.6 to .deps/EXCLUDED/prod.md; remove cron-parser@5.5.0 Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Claude Sonnet 4.6 (1M context) Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1504 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1504", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1504 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1504", name: che-dashboard}]}}]" |
Assisted-by: Claude Sonnet 4.6 (1M context) Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Claude Sonnet 4.6 (1M context) Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1504 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1504", name: che-dashboard}]}}]" |
1 similar comment
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1504 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1504", name: che-dashboard}]}}]" |
…om child Assisted-by: Claude Sonnet 4.6 (1M context) Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1504 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1504", name: che-dashboard}]}}]" |
…ecentItem - Add test suite for findApi helper covering all branches (with/without version) - Add test suite for getServiceAccountToken covering local run, file read, and missing file paths - Add Space key, bubbled-Enter, and mouse hover tests to NavigationRecentItem Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1504 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1504", name: che-dashboard}]}}]" |
|
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What does this PR do?
Bundles several independent UI polish and accessibility improvements to the Dashboard:
Update copyright year to 2026 across all source files (
2018-2025→2018-2026).Bump transitive/direct dependencies to address known CVEs and keep versions current:
handlebars4.7.8 → 4.7.9yaml2.8.2 → 2.8.3picomatch2.3.1 → 2.3.2fastify5.7.4 → 5.8.3undici7.22.0 → 7.24.5svgo3.0.2 → 3.3.3Upgrade base Docker image from
ubi8/nodejs-18toubi9/nodejs-20inbuild/dockerfiles/rhel.Dockerfile.Improve keyboard accessibility and icon hover styles for toolbar switches and the bulk-selector:
TemporaryStorageSwitchandCreateNewIfExistSwitchcan now be toggled with Tab + Enter.BulkSelectordropdown is fully keyboard-navigable.Fix
ErrorReporterfull-screen overlay so it always covers the sidebar.Add "Sign out" button to the error rendered by
IssueComponent(if preload data fail).Add "OpenShift console" link to the error rendered by
IssueComponent(if preload data fail).The link is invisible on non-OpenShift deployments.
Fix tooltip link colours in
CheTooltip.Screenshot/screencast of this PR
What issues does this PR fix or reference?
Is it tested? How?
Deploy Eclipse Che with the image built from this PR, then verify each point below.
Keyboard accessibility — recent workspace items:
Keyboard accessibility — toolbar switches and BulkSelector:
ErrorReporter overlay:
eclipse-che→ Deployments →che→ scale pods to0. Wait until the pod is gone.ErrorReporterwidget is centered and covers the sidebar completely.Release Notes
Docs PR