Handle byte-path Jsonnet imports to prevent apply-time provisioning failures#657
Draft
Copilot wants to merge 2 commits into
Draft
Handle byte-path Jsonnet imports to prevent apply-time provisioning failures#657Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/eclipse-csi/otterdog/sessions/fa876869-cace-485b-859f-f347247e0aee Co-authored-by: mbarbero <452625+mbarbero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Otterdog repository provisioning error during PR merge
Handle byte-path Jsonnet imports to prevent apply-time provisioning failures
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otterdog could report
The changes could not be applied successfullydue to a Jsonnet evaluator type error (bytespassed wherestrwas expected) during apply/provisioning, while the PR was already merged. This change removes that runtime type mismatch in the Jsonnet import callback path.Root-cause fix: normalize callback inputs before path resolution
otterdog.utils._make_jsonnet_import_callback(...)to acceptstr | bytesfor callback args and normalize viaos.fsdecode(...).Regression coverage
test_jsonnet_import_callback_accepts_byte_pathsintests/test_utils.py.base/relinputs and still resolves/returns expected content.