Handle missing parent org web settings without crashing import/apply#658
Draft
Copilot wants to merge 3 commits into
Draft
Handle missing parent org web settings without crashing import/apply#658Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/eclipse-csi/otterdog/sessions/458b5279-68dc-4681-ad41-dd20baa70eb6 Co-authored-by: mbarbero <452625+mbarbero@users.noreply.github.com>
Agent-Logs-Url: https://github.com/eclipse-csi/otterdog/sessions/458b5279-68dc-4681-ad41-dd20baa70eb6 Co-authored-by: mbarbero <452625+mbarbero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix errors retrieving organization settings for eclipse-cfm
Handle missing parent org web settings without crashing import/apply
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import/apply for some orgs (notably
eclipse-cfm) fails when several web-only org settings are absent in GitHub UI and retrieval reacheshas_discussions. The current flow can raise on dependent settings when their parent setting was not retrieved.Web settings retrieval hardening
WebClient._retrieve_settingsto guard parent-dependent settings lookup.parent:None,False, keep existing behavior (None+ continue).Targeted regression coverage
{"discussion_source_repository": None}for dependent setting.Example of the new parent guard behavior: