refactor: drop imperative DOM logic in AddLinkTdDialog#205
refactor: drop imperative DOM logic in AddLinkTdDialog#205Rohithgvmg wants to merge 2 commits intoeclipse-editdor:masterfrom
Conversation
Signed-off-by: Rohith <rgvmanikanta05@gmail.com>
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TejInaco
left a comment
TejInaco
left a comment
There was a problem hiding this comment.
Thanks for your work @Rohithgvmg. Almost done. A few details to do. Check the pending comments
| @@ -231,6 +260,13 @@ const AddLinkTdDialog = forwardRef<AddLinkTdDialogRef, AddLinkTdDialogProps>( | |||
| id="type" | |||
| className="w-full rounded-md border-2 border-gray-600 bg-gray-600 p-2 text-white focus:border-blue-500 focus:outline-none sm:text-sm" | |||
There was a problem hiding this comment.
Refactor this input and datalist in a way that it is possible to reuse the components/base/Dropdown.tsx component. Do the same for the local component RelationType.
| placeholder="The target ressource" | ||
| onChange={() => { | ||
| clearHrefErrorMessage(); | ||
| className={`rounded-md border-2 bg-gray-600 p-2 text-white focus:outline-none sm:text-sm ${ |
There was a problem hiding this comment.
The user needs to known what kind of option has chosen after click. After click the button clicked must remain the color blue-500. Remember that the default selection and when the usr clicks on "Resource url" the color changes in the button "From local machine"
|
Duplicate PR. Committer open two PR for the same issue. |
|
not intentionally, actually i lost track of this local branch, hence new branch/PR is created |
2 participants
Closes #201
Verified locally the changes
-Verified that typing and file uploads correctly sync with the component state.
-Confirmed that "The href field is mandatory" now correctly triggers on empty submissions. #