Another merge of 3.1 to 4.x#6103
Merged
Merged
Conversation
* Fix memory leak beanManager was set to threadLocal from a configurator that was post-init after the ComponentProvider configurator which is supposed to free the thread local. The beanManager thread local was never removed afterwards. I switched the order of calling post-init so that configurators go in reversed order compared to calling init * Fix memory leak - fix failing tests Revert the change to run postInit on all configurators in reversed order. Instead run postInit only on the specific Component configurator last, while initialize runs in the original order. This cleans up thread locals safely, without changing the order of other configurators, which was breking other functionality.
…6-3.1-fix-memory-leak Fix memory leak (port to 3.1)
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Fixed schemaLocation for poms
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Is be visible in test logs Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…cessing Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- The original test was created by guerrillakg, and was squashed and further updated by David Matejcek. - Both users signed ECA. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…tition Removed duplicit completion
# By David Matějček (6) and others # Via GitHub (3) and David Matějček (1) * eclipse/3.1: Removed supplier from log Added test from PR eclipse-ee4j#6086 Removed redundant surefire plugin without a version from helidon3-client Removed CompletedAsyncContextListener which redundantly completed processing Added logging of the redundant completition New test for AsyncContextDelegateProviderImpl Fixed schemaLocation for poms Fix memory leak (eclipse-ee4j#6075) Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Contributor
Author
|
Local result with the HK2 update: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local execution:
Why I hurried with this PR - 4.x has more tests than 3.1, so I wanted to see if these fixes will pass all of them.
However on CI there was yet some exception related to HK2, so I also updated the milestone to 4.0.1, see changes:
https://github.com/eclipse-ee4j/glassfish-hk2/releases/tag/4.0.1
https://github.com/eclipse-ee4j/glassfish-hk2/releases/tag/4.0.0 , more exactly eclipse-ee4j/glassfish-hk2@4.0.0-M3-RELEASE...4.0.0