Skip to content

[RelEng] Remove explicit versions from p2-repository #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HannesWell wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

[RelEng] Remove explicit versions from p2-repository #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions maven/org.eclipse.emf.mwe2.repository/category.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
<feature id="org.eclipse.emf.mwe.sdk" version="0.0.0">
<category name="mwe2lang"/>
</feature>
<bundle id="com.google.guava" version="33.5.0.qualifier"/>

@cdietrich cdietrich Mar 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am not sure if we will end up with multiple versions again

@HannesWell HannesWell Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be only the latest version, like with 0.0.0.
Of course if mwe references an earlier version of Guava that one is missing. But as far as I know MWE doesn't have special restrictions on Guava?

Of course if MWE would be migrated off Guava, that wouldn't be necessary at all (only as transitive dependency for Xtext maybe):

But that's another topic.

@cdietrich cdietrich Mar 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we try to use consisten versions in the xtext / mwe / xpect ecosystem and had problems in the past. this is why we initially bundle consistent versions over the place.
so i dont know if we will get in a state again where there is more than one version availble
(might be worse with cli as that one might also be used by other places in simrel)

@cdietrich cdietrich Mar 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and ofc migrate off wont work as we inherit it from xtext

<bundle id="com.google.guava.failureaccess" version="1.0.3.qualifier"/>
<bundle id="org.apache.commons.cli" version="1.11.0"/>
<bundle id="org.apache.commons.commons-logging" version="0.0.0"/>
<bundle id="com.google.guava"/>
<bundle id="com.google.guava.failureaccess"/>
<bundle id="org.apache.commons.cli"/>
<bundle id="org.apache.commons.commons-logging"/>
<category-def name="mwe2lang" label="MWE">
<description>
The configuration language used to configure Xtext&apos;s code generator.
Expand Down