Keep lwIP netif persistent across lifecycle transitions#411
Open
amit-warbhe wants to merge 1 commit intoeclipse-openbsw:mainfrom
Open
Keep lwIP netif persistent across lifecycle transitions#411amit-warbhe wants to merge 1 commit intoeclipse-openbsw:mainfrom
amit-warbhe wants to merge 1 commit intoeclipse-openbsw:mainfrom
Conversation
After Lifecycle transition 9 → 4 → 9, UDP multicast join failed with: igmp_joingroup failed with status -6 because EthernetSystem::init() was only executed once during system lifetime, while run() is re-executed after lifecycle restart. Network interface configuration was performed inside init(). During LC restart (4 → 9), init() was not called again, therefore the lwIP netif was not properly reconfigured. Moving all netif-specific configuration and activation logic into run() solves the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep lwIP netif persistent across lifecycle transitions
After Lifecycle transition 9 → 4 → 9, UDP multicast join failed with:
igmp_joingroup failed with status -6
because EthernetSystem::init() was only executed once during system lifetime,
while run() is re-executed after lifecycle restart.
Network interface configuration was performed inside init().
During LC restart (4 → 9), init() was not called again, therefore
the lwIP netif was not properly reconfigured.
Moving all netif-specific configuration and activation logic into run() solves the issue.