Fix ENET ISR race during Ethernet driver initialization#412
Open
amit-warbhe wants to merge 1 commit intoeclipse-openbsw:mainfrom
Open
Fix ENET ISR race during Ethernet driver initialization#412amit-warbhe wants to merge 1 commit intoeclipse-openbsw:mainfrom
amit-warbhe wants to merge 1 commit intoeclipse-openbsw:mainfrom
Conversation
The ENET ISR could access the Ethernet driver before it was fully initialized. The ethernet driver pointer (pEnetDriver) was assigned during init(), which exposed the driver to interrupts before driver.start() completed. If an ENET interrupt occurred during this window, the ISR could call interruptGroup0() on a partially initialized driver, leading to undefined behaviour which resulted in HardFault or sometimes system reset. Move the assignment of pEnetDriver from init() to run() so the driver is only exposed to the ISR after driver.start() completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ENET ISR race during Ethernet driver initialization
The ENET ISR could access the Ethernet driver before it was fully initialized.
The ethernet driver pointer (pEnetDriver) was assigned during init(),
which exposed the driver to interrupts before driver.start() completed.
If an ENET interrupt occurred during this window, the ISR could call interruptGroup0() on a
partially initialized driver, leading to undefined behaviour which resulted in HardFault or sometimes
system reset.
Move the assignment of pEnetDriver from init() to run() so the driver is only exposed to the ISR
after driver.start() completes.