-
Notifications
You must be signed in to change notification settings - Fork 123
Add missing bundle so that UpdateUnitVersionsCommandTests doesn't fail when ran from Eclipse #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring a concrete implementation her is likely wrong in many ways.
Instead the provider needs to provide approciate capbilty (service or implementor) and the consumer (where NPE occures) require appropriate requirement (either service or implementor capabilty)
A consumer bunlde like this should not need any of those!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e. I should be opening a ticket for
org.eclipse.equinox.p2.repository?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't get too fussed out about the best, proper, correct way for a test; it's only an opinion. There aren't so many folks writing new p2-based application that will benefit from improved ways to specify dependencies; it's an assumption with not statistical basis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if I run the code from the stack trace in any launch, it will fail unless I have a dependency like the one here? Something must be missing either in the launch configuration or in the dependencies. If this can be fixed centrally or if the launch configuration code has errors, best to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like to solve it yes it would be the right place but be prepared that you likely need to drive that on your own (but we can help).
To see how it work in general you can look at this recent PR:
eclipse-equinox/equinox#1206
or how SWT handle the svg requirements, we also have examples for declarative services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK @laeubi , lets continue here then: eclipse-equinox/p2#972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that all the tests pass seems like a good thing. Future improvement could be saved for the future...