Issue 2005 import spy adapter

[amelodev]

Fixes #2005

org.eclipse.pde.spy.adapter bundle added to the PDE spies collection.
This new spy provides a view of the available adapter factories.

There is one issue I have not been able to resolve yet — the Adapter Spy shortcut does not seem to work.

This problem also appears to affect other spies such as the Event Spy and the Context Spy.

[github-actions]

Test Results

  147 files  ±0    147 suites  ±0   36m 18s ⏱️ - 2m 41s
3 493 tests ±0  3 439 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 303 runs  ±0  9 173 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit 1445add. ± Comparison against base commit 693ecb5.

♻️ This comment has been updated with latest results.

[laeubi]

We would need a CQ here to import the code into PDE if approved by PL.
Smaller issues can be fixed afterwards.

[amelodev]

iplab issue https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/25593 is closed

[iloveeclipse]

I did a short smoke test, no real code review but just some few basic checks.

In general looks useful, however I was missing some adapters and couldn't really figure out why.

For example, I've missed java.io.File adapter factory contributed here
https://github.com/iloveeclipse/anyedittools/blob/a8eaa4995f7724b871375d250e87dcdd2973c82b/AnyEditTools/plugin.xml#L626-L632

and here:

https://github.com/iloveeclipse/anyedittools/blob/a8eaa4995f7724b871375d250e87dcdd2973c82b/AnyEditTools/src/de/loskutov/anyedit/ui/editor/EditorAdapterFactory.java#L70-L72

Also three filtering seem to work in a very strange way, even if table shows java.io.File, entering File in the filter sometimes shows some unrelated matches but not java.io.File, and sometimes it shows it.

Beside this, please rebase (not merge) your branch on top of latest master commit.

[iloveeclipse]

@amelodev : please could you mark all comments on PR as resolved if they are already addressed by the latest change, and those that are unresolved give a comment why not?

[Copilot]

Pull request overview

This PR imports the adapter spy plugin (org.eclipse.pde.spy.adapter) from an external source into the PDE spies collection. The adapter spy provides a view to display all available adapter factories in the Eclipse runtime, showing which source types can be adapted to which destination types. The plugin was originally developed by lacherp and has been renamed from org.eclipse.e4.tools.adapter.spy to fit the PDE naming convention.

Changes:

• Added new org.eclipse.pde.spy.adapter bundle with complete source code, icons, and metadata
• Includes model classes for adapter data representation, viewer components for tree display, and helper utilities for adapter introspection
• Integrated with the PDE spy framework using the org.eclipse.pde.spy.core.spyPart extension point

Reviewed changes

Copilot reviewed 24 out of 30 changed files in this pull request and generated 22 comments.

Show a summary per file

File	Description
META-INF/MANIFEST.MF	Bundle manifest defining dependencies and execution environment (JavaSE-21)
plugin.xml	Extension point registration for the adapter spy part
plugin.properties	Localized bundle metadata and descriptions
build.properties	Build configuration specifying source and output directories
.project/.classpath/.settings/*	Eclipse project configuration files
src/org/eclipse/pde/spy/adapter/AdapterSpyPart.java	Main UI part creating the tree viewer and toolbar controls
src/org/eclipse/pde/spy/adapter/Messages.java	NLS message accessor class
src/org/eclipse/pde/spy/adapter/Messages.properties	Internationalized message strings
src/org/eclipse/pde/spy/adapter/model/*	Model classes (AdapterData, AdapterRepository, AdapterElementType)
src/org/eclipse/pde/spy/adapter/viewer/*	Viewer support classes (content providers, filters, comparators)
src/org/eclipse/pde/spy/adapter/tools/AdapterHelper.java	Helper utilities for adapter introspection
src/org/eclipse/pde/spy/adapter/hook/EclipseAdapterHook.java	Hook to intercept Eclipse adapter calls
icons/*	Image resources for the spy UI
about.html/notice.html	Legal documentation files

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.