Replace String.valueOf(true) with "true" literal#2265
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Mar 23, 2026
Merged
Replace String.valueOf(true) with "true" literal#2265laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
String.valueOf(true) is unnecessarily verbose and incurs a method call. A string literal is clearer and avoids unnecessary overhead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
laeubi
force-pushed
the
fix/string-valueof-true-literal
branch
from
b7c76b3 to
0116d1e
Compare
Contributor
|
LGTM |
Contributor
|
Btw. IIRC we have a JDT clean-up for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
String.valueOf(true)with a string literal"true"inUpdateSingletonToSymbolicName.java.String.valueOf(true)is unnecessarily verbose and incurs a method call. A string literal is clearer and avoids unnecessary overhead.