Skip to content

Replace Boolean.TRUE.toString().equals() with Boolean.parseBoolean() #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laeubi merged 1 commit into from
Mar 23, 2026
Merged

Replace Boolean.TRUE.toString().equals() with Boolean.parseBoolean() #2267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/exports/FeatureOptionsTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ protected void initialize(IDialogSettings settings) {
}

String selected = settings.get(S_EXPORT_METADATA);
fExportMetadata.setSelection(selected == null ? true : Boolean.TRUE.toString().equals(selected));
fExportMetadata.setSelection(selected == null || Boolean.parseBoolean(selected));

// This enablement depends on both the jar button being selected and the destination setting being something other than install (bug 276989)
fExportMetadata.setEnabled(fJarButton.getSelection());
Expand All @@ -207,7 +207,7 @@ protected void initialize(IDialogSettings settings) {
selected = settings.get(S_CREATE_CATEGORIES);

fCategoryButton.setEnabled(fExportMetadata.getSelection() && fJarButton.getSelection());
fCategoryButton.setSelection(selected == null ? true : Boolean.TRUE.toString().equals(selected));
fCategoryButton.setSelection(selected == null || Boolean.parseBoolean(selected));
if (settings.get(S_CATEGORY_FILE) != null) {
fCategoryCombo.setText(settings.get(S_CATEGORY_FILE));
}
Expand Down
4 changes: 2 additions & 2 deletions ...lipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/exports/ProductExportWizardPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@ protected void initialize() {
fExportSourceCombo.setEnabled(fExportSourceButton.getSelection());

String selected = settings.get(S_EXPORT_METADATA);
fExportMetadata.setSelection(selected == null ? true : Boolean.TRUE.toString().equals(selected));
fExportMetadata.setSelection(selected == null || Boolean.parseBoolean(selected));

selected = settings.get(S_ALLOW_BINARY_CYCLES);
fAllowBinaryCycles.setSelection(selected == null ? true : Boolean.TRUE.toString().equals(selected));
fAllowBinaryCycles.setSelection(selected == null || Boolean.parseBoolean(selected));

if (fMultiPlatform != null) {
fMultiPlatform.setSelection(settings.getBoolean(S_MULTI_PLATFORM));
Expand Down
Loading