Replace StringBuffer with StringBuilder in AntScript#2268
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Mar 24, 2026
Merged
Conversation
StringBuffer is synchronized and thus slower than StringBuilder. The local variable in getEscaped() is not shared across threads, so StringBuilder is the appropriate choice here. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
laeubi
force-pushed
the
fix/stringbuffer-to-stringbuilder-antscript
branch
from
ddeedef to
70984fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the synchronized
StringBufferwithStringBuilderinAntScript.getEscaped()and the private helperappendEscapedChar().The local variable is not shared across threads, so
StringBuilderis the appropriate choice and avoids unnecessary synchronization overhead.