Skip to content

[FIX] dispose code mining providers#3770

Merged
BeckerWdf merged 1 commit intoeclipse-platform:masterfrom
marcushoepfner:fix-code-mining-dispose
Mar 10, 2026
Merged

[FIX] dispose code mining providers#3770
BeckerWdf merged 1 commit intoeclipse-platform:masterfrom
marcushoepfner:fix-code-mining-dispose

Conversation

@marcushoepfner
Copy link
Contributor

@marcushoepfner marcushoepfner commented Mar 10, 2026

Fixes: eclipse-jdt/eclipse.jdt.ui#2856

JDT does the same in JavaEditor.uninstallJavaCodeMining().

Seems that this was completely missing for e.g. text editors.

Fixes: eclipse-jdt/eclipse.jdt.ui#2856

JDT does the same in JavaEditor.uninstallJavaCodeMining().

Seems that this was completely missing for e.g. text editords.
@github-actions
Copy link
Contributor

Test Results

   852 files  ±0     852 suites  ±0   56m 35s ⏱️ + 1m 4s
 7 848 tests ±0   7 605 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 070 runs  ±0  19 414 ✅ ±0  656 💤 ±0  0 ❌ ±0 

Results for commit 54d3eed. ± Comparison against base commit a39ccc6.

Copy link
Contributor

@tobiasmelcher tobiasmelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot Marcus

@BeckerWdf BeckerWdf added this to the 4.40 M1 milestone Mar 10, 2026
@BeckerWdf BeckerWdf merged commit 9c4efac into eclipse-platform:master Mar 10, 2026
18 checks passed
@marcushoepfner marcushoepfner deleted the fix-code-mining-dispose branch March 10, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

16 JavaLeakTest tests failing since I20260309-1800

3 participants