Skip to content

containers: add ScoreDebug and Debug#83

Merged
pawelrutkaq merged 2 commits intoeclipse-score:mainfrom
qorix-group:arkjedrz_containers-score-debug
Mar 27, 2026
Merged

containers: add ScoreDebug and Debug#83
pawelrutkaq merged 2 commits intoeclipse-score:mainfrom
qorix-group:arkjedrz_containers-score-debug

Conversation

@arkjedrz
Copy link
Copy Markdown
Contributor

Add ScoreDebug and Debug implementations.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #82

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: cd1d290a-1dba-40bd-95f7-6095f65d9d2a
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_rust', the root module requires module version rules_rust@0.61.0, but got rules_rust@0.67.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.14 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (32 packages loaded, 9 targets configured)

Analyzing: target //:license-check (87 packages loaded, 9 targets configured)

Analyzing: target //:license-check (143 packages loaded, 1088 targets configured)

Analyzing: target //:license-check (143 packages loaded, 1088 targets configured)

Analyzing: target //:license-check (153 packages loaded, 2126 targets configured)

Analyzing: target //:license-check (164 packages loaded, 3226 targets configured)

Analyzing: target //:license-check (165 packages loaded, 3236 targets configured)

Analyzing: target //:license-check (165 packages loaded, 3236 targets configured)

Analyzing: target //:license-check (165 packages loaded, 3236 targets configured)

Analyzing: target //:license-check (167 packages loaded, 3520 targets configured)

Analyzing: target //:license-check (169 packages loaded, 5249 targets configured)

Analyzing: target //:license-check (197 packages loaded, 5552 targets configured)
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 5 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
Analyzing: target //:license-check (197 packages loaded, 5552 targets configured)
[15 / 17] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (197 packages loaded, 5552 targets configured)
[16 / 17] [Prepa] Building license.check.license_check.jar ()
Analyzing: target //:license-check (197 packages loaded, 5552 targets configured)
[17 / 17] no actions running
INFO: Analyzed target //:license-check (198 packages loaded, 9886 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.877s, Critical Path: 3.09s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ScoreDebug (and missing Debug) implementations across the containers crate to support SCORE logging-format debug output and improve debuggability of container types (per Issue #82).

Changes:

  • Implement score_log::fmt::ScoreDebug for multiple inline, generic, and fixed-capacity container types.
  • Add/adjust core::fmt::Debug implementations where missing (notably queues).
  • Wire in score_log as a dependency (Cargo + Bazel), updating lockfile accordingly.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/containers/inline/vec.rs Add ScoreDebug for InlineVec by delegating to slice formatting.
src/containers/inline/string.rs Add ScoreDebug for InlineString by delegating to str.
src/containers/inline/result.rs Add ScoreDebug for InlineResult (currently delegates to Result<&T,&E>).
src/containers/inline/queue.rs Add Debug + ScoreDebug for InlineQueue delegating to inner queue.
src/containers/inline/option.rs Add ScoreDebug for InlineOption delegating to Option<&T>.
src/containers/generic/vec.rs Add ScoreDebug for GenericVec delegating to slice formatting.
src/containers/generic/string.rs Add ScoreDebug for GenericString delegating to str.
src/containers/generic/queue.rs Add Debug + ScoreDebug for GenericQueue using list-style formatting.
src/containers/fixed_capacity/vec.rs Add ScoreDebug for fixed-capacity vectors (both In and wrapper).
src/containers/fixed_capacity/string.rs Add ScoreDebug for fixed-capacity strings (and adjust Debug delegation).
src/containers/fixed_capacity/queue.rs Add Debug + ScoreDebug for FixedCapacityQueueIn.
src/containers/Cargo.toml Add score_log workspace dependency.
src/containers/BUILD Add Bazel dependency on //src/log/score_log.
Cargo.lock Record new score_log dependency in lockfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arkjedrz arkjedrz force-pushed the arkjedrz_containers-score-debug branch from 78bea98 to ce371bc Compare March 26, 2026 13:15
@arkjedrz arkjedrz requested a deployment to workflow-approval March 26, 2026 13:15 — with GitHub Actions Waiting
@arkjedrz arkjedrz requested a deployment to workflow-approval March 26, 2026 13:15 — with GitHub Actions Waiting
@arkjedrz arkjedrz requested a review from Copilot March 26, 2026 13:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 14 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add `ScoreDebug` and `Debug` implementations.
@arkjedrz arkjedrz force-pushed the arkjedrz_containers-score-debug branch from ce371bc to 544c1af Compare March 26, 2026 14:04
@arkjedrz arkjedrz requested a deployment to workflow-approval March 26, 2026 14:04 — with GitHub Actions Waiting
@arkjedrz arkjedrz requested a deployment to workflow-approval March 26, 2026 14:04 — with GitHub Actions Waiting
Copy link
Copy Markdown
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we can remove boilerplate impls which jsut call one liners?

- Remove gated features.
- Remove `no_std` from containers.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arkjedrz arkjedrz marked this pull request as ready for review March 27, 2026 10:57
@github-project-automation github-project-automation bot moved this from In Progress to On Hold in BAS - Baselibs FT Mar 27, 2026
@pawelrutkaq pawelrutkaq merged commit 6fe5f0e into eclipse-score:main Mar 27, 2026
18 checks passed
@github-project-automation github-project-automation bot moved this from On Hold to Done in BAS - Baselibs FT Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improvement: Add Debug and ScoreDebug where applicable in containers

3 participants