Add pre-commit feature and bump versions #66
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurtz
changed the title
Contributor
Author
|
I would wait for feedback from @mikehaller before merging this |
opajonk
reviewed
Jan 29, 2026
Comment on lines
40
to
42
| "ghcr.io/devcontainers-extra/features/pre-commit:2": { | ||
| "version": "4.5.1" | ||
| }, |
Contributor
There was a problem hiding this comment.
One thing may be missing: pre-commit install needs to be triggered. I have seen that in a postCreateCommand.
mikehaller
approved these changes
Jan 29, 2026
mikehaller
left a comment
mikehaller
left a comment
There was a problem hiding this comment.
Doing the install into git by default would be nice, but could also be done repo specific.
lurtz
force-pushed
the
add-pre-commit-feature
branch
from
3116640 to
1c81846
Compare
Contributor
Author
Should be done now |
lurtz
force-pushed
the
add-pre-commit-feature
branch
from
1c81846 to
b5b1d4f
Compare
It supports to spot easy to detect issues before committing code and reduce the number of failed CI runs and review cycles. Ensure the S-CORE depends on the pre-commit feature so that it is always because it installs scripts using it.
lurtz
force-pushed
the
add-pre-commit-feature
branch
from
6f3a1fc to
b0ec723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit helps to reduce CI load and review cycles.
We should eventually introduce something like dependabot if we do not want to spend a lot of time bumping versions.
Closes #62