Extract bazel feature from S-CORE feature #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurtz
force-pushed
the
extract-bazel-feature
branch
from
c2bfb67 to
09892c8
Compare
lurtz
changed the title
opajonk
suggested changes
Jan 30, 2026
Contributor
opajonk
left a comment
opajonk
left a comment
There was a problem hiding this comment.
In general a good idea, we should merge this. Just one detail about an implicit dependency.
opajonk
approved these changes
Jan 30, 2026
lurtz
force-pushed
the
extract-bazel-feature
branch
from
22ec259 to
d670962
Compare
FScholPer
previously approved these changes
Jan 30, 2026
bazel related code is a lot and sould be isolated in a dedicated feature. It is already some code and this way the scope is better isolated.
lurtz
force-pushed
the
extract-bazel-feature
branch
from
d670962 to
274f816
Compare
FScholPer
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel related code is a lot and sould be isolated in a dedicated feature.