Fix incorrect memory layout on Rust >= 1.67.0#28
Merged
TruongQuangSB merged 1 commit intomainfrom Sep 11, 2023
Merged
Conversation
License summary❌ Not yet vetted dependencies:
Workflow run (with attached summary files): |
TruongQuangSB
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rust 1.67.0, the Rust compiler groups fields in a struct if it improves alignment. See rust-lang/rust#102750 for details. Prior to that change, in some cases
repr(Rust)andrepr(C)structs had the same memory layout, which now differs, breaking C<=>Rust interfacing.We've had a few instances in the code where we (implicitly) relied on the memory layout being equivalent to
repr(C), which stopped some of the browser functions from working if compiled with a newer Rust version.