[PLANPRO-5832] Signal ausleger with foundation#2047
[PLANPRO-5832] Signal ausleger with foundation#2047JanErikVoigt wants to merge 43 commits intoeclipse-set:mainfrom
Conversation
|
Signals are now shown as Ausleger. It still looks wrong, but I think thats for a different ticket. 7707 and 7705 A95E3164-CDA3-47A5-963E-77A8B6BE1AAF: |
...et.feature.siteplan/src/org/eclipse/set/feature/siteplan/transform/SignalTransformator.xtend
Outdated
Show resolved
Hide resolved
...et.feature.siteplan/src/org/eclipse/set/feature/siteplan/transform/SignalTransformator.xtend
Outdated
Show resolved
Hide resolved
| <circle r="10" cx="35" cy="20"/> | ||
| <circle r="10" cx="5" cy="40"/> | ||
| <toolbox:anchor id="mastAnkerTop" x="20" y="40" /> | ||
| <toolbox:anchor id="mastAnkerBottom" x="20" y="20"/> |
There was a problem hiding this comment.
actually the ``Vr1` haven't no anchor punkt, because the signal mast should be through between two circle
There was a problem hiding this comment.
I think they do, sometimes.
TruongQuangSB
left a comment
TruongQuangSB
left a comment
There was a problem hiding this comment.
pls resolve conflict with merge
...ndles/org.eclipse.set.model.siteplan/src/org/eclipse/set/model/siteplan/SignalMountType.java
Show resolved
Hide resolved
....eclipse.set.model.siteplan/src/org/eclipse/set/model/siteplan/impl/SiteplanPackageImpl.java
Show resolved
Hide resolved
| * @param label {@link Label} | ||
| */ | ||
| public abstract drawSVG<T extends object>(data: T, label?: Label): ISvgElement | ||
| public abstract drawSVG<T extends object>(data: T, label?: Label): ISvgElement | null |
There was a problem hiding this comment.
instead of null should it give SvgError back, when something wrong
There was a problem hiding this comment.
I made SvgDrawBridge an AbstractDrawSVG. Now, there are two for Signals... (SvgDrawSignal and SvgDrawBridge). Don't you think it is sensible to model it like this? Now flow is:
- SvgDrawBridge attempts to draw, if it is not a bridge, returns null
- SvgService continues searching for a result != null
- Then SvgDrawSignal returns a value != null.
- if it, too, returns null, draw error
JanErikVoigt
force-pushed
the
signal-ausleger-with-foundation
branch
from
5d06764 to
faf9daa
Compare
2 participants
No description provided.