Replace Maven dependency with python native proto binding and submodule workflow #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency, Upgraded code for latest up-spec 7af90bd9aee517e79b7a41427d37de28af0f6de0
- Removed Maven dependency references in README as they are no longer needed. - Updated instructions to reflect using `up-spec` as a git submodule. - Added steps to run `scripts/generate_proto.py` for generating local Python proto bindings. - Aligned workflow with the new approach of managing `up-core-api` protos locally instead of pulling during build. - Ensured instructions remain clean for new contributors while reflecting the deprecated proto subscribe handling updates.
AnotherDaniel
left a comment
AnotherDaniel
left a comment
There was a problem hiding this comment.
Nice! Some minor mostly editorial comments...
generate_proto.py
Outdated
| @@ -0,0 +1,67 @@ | |||
| """ | |||
| SPDX-FileCopyrightText: 2024 Contributors to the Eclipse Foundation | |||
|
Code coverage report is ready! 📈
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the up-python build and development workflow by:
Motivation
Notes
Let me know if further adjustments are needed or if you prefer additional documentation updates. Thank you for reviewing!