-
Notifications
You must be signed in to change notification settings - Fork 329
Update to Java 25, Newer tps, etc #3638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
66f156e
bump versions to 21
cdietrich 6b9dbb5
Java 25 constant
cdietrich c72bd4a
WIzard ajustments
cdietrich 9118f32
bump tycho version
cdietrich 284464b
attempt to fix tycho5 build
cdietrich dc6b83f
fix launches
cdietrich 809d78c
wizard adjustment
cdietrich 3f919fe
more adjustments
cdietrich 0f31639
fixes
cdietrich f77e42e
another fix
cdietrich bc07ec3
typo fix
cdietrich fafed39
more fixes
cdietrich 074e8ee
fixes
cdietrich ede9d79
typos
cdietrich 087b3e8
fix test expectations
cdietrich df0499c
bump bom versions
cdietrich 0d65523
attemp to fix tycho mimimi
cdietrich 3b8423a
bump versions in manifest
cdietrich eaf820c
More mf bumps
cdietrich d9cd78a
attempt to also build the relocations
cdietrich fc1f665
Merge pull request #3639 from eclipse-xtext/cd-bump-in-manifests
cdietrich 184ab76
wizard workarcound
cdietrich 13a2722
temp. disable test
cdietrich 4893c04
always run with 25
cdietrich 8abe5c4
Merge remote-tracking branch 'origin/main' into cd-big-bump
cdietrich 2eecc11
fix typo
cdietrich 2015541
fix merge conflict
cdietrich 91b14bf
more merge fixes
cdietrich 6827909
test adjustments
cdietrich 38a8b81
Merge remote-tracking branch 'origin/main' into cd-big-bump
cdietrich d765001
Merge remote-tracking branch 'origin/main' into cd-big-bump
cdietrich cc28581
fix hidden merge conflict
cdietrich 07f392e
more conflicts
cdietrich 16f452f
Merge remote-tracking branch 'origin/main' into cd-big-bump
cdietrich 376af94
restore order
cdietrich 3d395d4
fix: merge problems
cdietrich a37cf10
Merge remote-tracking branch 'origin/main' into cd-big-bump
cdietrich 609d11c
review feedback
cdietrich a4e183d
Merge remote-tracking branch 'origin/main' into cd-big-bump
cdietrich 40fcc7f
cleanup
cdietrich 6b293f3
Merge remote-tracking branch 'origin/main' into cd-big-bump
cdietrich 3048500
undo temp changes
cdietrich 51b8399
cleanup
cdietrich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
org.eclipse.xtext.tests/src/org/eclipse/xtext/util/JavaVersionTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...lipse.xtext.xtext.wizard/src/org/eclipse/xtext/xtext/wizard/ParentProjectDescriptor.xtend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
....xtext.xtext.wizard/xtend-gen/org/eclipse/xtext/xtext/wizard/ParentProjectDescriptor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HannesWell why did you have this if/else?
afaik all simrels are still on java 21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.
I believe I did this because support for Java-25 is better with 2026-03, although it works already with 2025-03.
Should I remove it and always use 2025-03?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe we can do the rest with this pr. i will undo the stuff to fullbuild.sh for now and then later on check with lorenzo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so ok with the remaineder of this pr? if yes ill merge once build is in, and tomorrow morning update the refefrence projects one as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me.
Thanks.
I'll have a look at mwe in the next days and will try to land my open PRs (I assume they need some adjustments now) and apply similar changes there too.