Move all Xtext Plug-ins to Java-21 and drop Java-17 support#3647
Merged
Conversation
Contributor
|
can you check the jenkins file changes on your side? |
Contributor
Author
Yes, it's already running in |
cdietrich
reviewed
Mar 12, 2026
cdietrich
approved these changes
Mar 12, 2026
1b1f0bd to
ada4f7b
Compare
Test Results 8 076 files ±0 8 076 suites ±0 3h 49m 11s ⏱️ + 7m 1s Results for commit 6ce4d01. ± Comparison against base commit 7091f26. This pull request removes 7 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Update the root pom.xml and Jenkinsfile to build with at least Java-21. Configure all Xtext Plug-ins to require Java-21. For all files named 'MANIFEST.MF', replace: 'JavaSE-17' -> 'JavaSE-21' For all files named '.classpath', replace: 'JavaSE-17' -> 'JavaSE-21' For all files named 'org.eclipse.jdt.core.prefs', replace: '.targetPlatform=17' -> '.targetPlatform=21' '.compiler.compliance=17' -> '.compiler.compliance=21' '.compiler.source=17' -> '.compiler.source=21' For all files matching the filename pattern '*.launch', replace: 'JavaSE-17' -> 'JavaSE-21' For all files named 'pom.xml', replace: '>17<' -> '>21<' For all files named 'MANIFEST.MF_gen', replace: 'JavaSE-17' -> 'JavaSE-21' From all of these modifications, exclude the files in folder - org.eclipse.xtext.tests/testdata
ada4f7b to
6ce4d01
Compare
Contributor
|
thx |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts from #3638 the changes to
Jenkinsfileand rootpom.xml, this change done completely mechanically by replacing occurrences of Java-17 patterns by their Java-21 pendants in the files listed in the commit message.