Skip to content

Move all Xtext Plug-ins to Java-21 and drop Java-17 support#3647

Merged
cdietrich merged 2 commits into
eclipse-xtext:mainfrom
HannesWell:require-java21
Mar 13, 2026
Merged

Move all Xtext Plug-ins to Java-21 and drop Java-17 support#3647
cdietrich merged 2 commits into
eclipse-xtext:mainfrom
HannesWell:require-java21

Conversation

@HannesWell

Copy link
Copy Markdown
Contributor

This extracts from #3638 the changes to

  1. Move all Xtext Plug-ins Java-21 and set minimum in build to Java-21
    • Except for the update the Jenkinsfile and root pom.xml, this change done completely mechanically by replacing occurrences of Java-17 patterns by their Java-21 pendants in the files listed in the commit message.
  2. Set Java-21 as minimum in wizard and drop support for Java-17

@cdietrich

Copy link
Copy Markdown
Contributor

can you check the jenkins file changes on your side?

@HannesWell

HannesWell commented Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

can you check the jenkins file changes on your side?

Yes, it's already running in

Comment thread Jenkinsfile
@github-actions

github-actions Bot commented Mar 12, 2026

Copy link
Copy Markdown

Test Results

  8 076 files  ±0    8 076 suites  ±0   3h 49m 11s ⏱️ + 7m 1s
 43 241 tests  - 1   42 657 ✅ +5    584 💤 ±0  0 ❌  - 6 
212 508 runs   - 5  209 587 ✅ +1  2 921 💤 ±0  0 ❌  - 6 

Results for commit 6ce4d01. ± Comparison against base commit 7091f26.

This pull request removes 7 and adds 6 tests. Note that renamed tests count towards both.
org.eclipse.xtext.xtext.wizard.WizardConfigurationTest ‑ allBuildSystemsUseJava17
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[11: Maven|Plain|HIERARCHICAL|Fat Jar]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[12: Gradle|Plain|HIERARCHICAL|Fat Jar]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[14: Maven|Plain|HIERARCHICAL|Regular]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[15: Gradle|Plain|HIERARCHICAL|Regular]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[8: Maven|Plain|HIERARCHICAL|None]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[9: Gradle|Plain|HIERARCHICAL|None]
org.eclipse.xtext.xtext.wizard.WizardConfigurationTest ‑ allBuildSystemsUseJava21
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[11: Gradle|Plain|HIERARCHICAL|Fat Jar]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[12: Maven|Plain|HIERARCHICAL|Regular]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[14: Gradle|Plain|HIERARCHICAL|Regular]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[8: Gradle|Plain|HIERARCHICAL|None]
org.eclipse.xtext.xtext.wizard.cli.CliWizardIntegrationTest ‑ testProjectCreation[9: Maven|Plain|HIERARCHICAL|Fat Jar]

♻️ This comment has been updated with latest results.

Update the root pom.xml and Jenkinsfile to build with at least Java-21.

Configure all Xtext Plug-ins to require Java-21.
For all files named 'MANIFEST.MF', replace:
'JavaSE-17' -> 'JavaSE-21'

For all files named '.classpath', replace:
'JavaSE-17' -> 'JavaSE-21'

For all files named 'org.eclipse.jdt.core.prefs', replace:
'.targetPlatform=17' -> '.targetPlatform=21'
'.compiler.compliance=17' -> '.compiler.compliance=21'
'.compiler.source=17' -> '.compiler.source=21'

For all files matching the filename pattern '*.launch', replace:
'JavaSE-17' -> 'JavaSE-21'

For all files named 'pom.xml', replace:
'>17<' -> '>21<'

For all files named 'MANIFEST.MF_gen', replace:
'JavaSE-17' -> 'JavaSE-21'

From all of these modifications, exclude the files in folder
- org.eclipse.xtext.tests/testdata
@HannesWell HannesWell changed the title Move all Xtext Plug-ins Java-21 and drop Java-17 support Move all Xtext Plug-ins to Java-21 and drop Java-17 support Mar 13, 2026
@cdietrich cdietrich merged commit 216aa26 into eclipse-xtext:main Mar 13, 2026
9 of 10 checks passed
@cdietrich

Copy link
Copy Markdown
Contributor

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants