Inline xtext.common.types.shared.jdt38 into xtext.xbase.ui#3729
Open
HannesWell wants to merge 1 commit into
Open
Inline xtext.common.types.shared.jdt38 into xtext.xbase.ui#3729HannesWell wants to merge 1 commit into
HannesWell wants to merge 1 commit into
Conversation
HannesWell
force-pushed
the
inline-xtext.common.types.shared.jdt38
branch
from
a2754ea to
71ff1d1
Compare
Test Results 8 064 files + 4 8 064 suites +4 3h 50m 51s ⏱️ + 9m 3s For more details on these failures, see this check. Results for commit 23493f6. ± Comparison against base commit ae4a39c. ♻️ This comment has been updated with latest results. |
Contributor
|
@iloveeclipse how do you solve this is your codebase? do you depend on the fragment + xbase.ui? |
Contributor
We ignore it :( |
HannesWell
force-pushed
the
inline-xtext.common.types.shared.jdt38
branch
from
71ff1d1 to
23493f6
Compare
Contributor
Author
|
Is there anything missing here or do you want me to adjust something? I just resolved the conflicts and rebased this on the latest master commit. |
Contributor
|
i cannot judge so leave to @szarnekow to find time to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3718
While implementing this I noticed that just inlining the fragment into its host
org.eclipse.xtext.common.types.sharedand adding the required (optional) dependencies leads to a dependency cycle withorg.eclipse.xtext.xbase.uiand is therefore not feasible.Since
OriginalEditorSelectorrequires types fromorg.eclipse.xtext.xbase.ui, I found thatorg.eclipse.xtext.xbase.uiis probably the better target.Placing it there does not require the addition of any new dependency in the target bundle and should not make a difference since
org.eclipse.xtext.xbase.uiwas always a prerequisite to make theOriginalEditorSelectorwork.And since the
DebugPluginListeneris only referenced byOriginalEditorSelectorI moved it intoorg.eclipse.xtext.xbase.uitoo.Additionally this fixes some warnings and avoids Guava in the moved classes.
@cdietrich and @szarnekow, please have a look.