Skip to content

Clessig/develop/fix io forcing#2445

Open
clessig wants to merge 17 commits into
develop-sslfrom
clessig/develop/fix_io_forcing
Open

Clessig/develop/fix io forcing#2445
clessig wants to merge 17 commits into
develop-sslfrom
clessig/develop/fix_io_forcing

Conversation

@clessig

@clessig clessig commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix IO with forcing datasets

Issue Number

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

clessig and others added 17 commits May 22, 2026 17:53
Co-authored-by: Tharmeekan <tsivalingam@ethz.ch>
…2414)

* Handle scalar datetimes in time encoders

* Keep single target times one-dimensional

---------

Co-authored-by: Christian Lessig <christian.lessig@ecmwf.int>
* ensure samples_per_mini_epoch >= world_size*batch_size

* updated warning log
* Fix logging when NaNs occur

* fix nan variables being included in terminal logged loss, replace nan by 0

* Removing incorrect reset

---------

Co-authored-by: Sebastian Hickman <seb.hickman@gmail.com>
…fied projection logic (#2401)

* added arctic region for plotting in stereographic projection and modified projection logic

* new projection logic in plotter

* restored attention and positional_encoding

* added icon, arome, uwc-west regions

* removing accidental file

---------

Co-authored-by: Matteo Broccoli <mbroccol@login01.leonardo.local>
Co-authored-by: iluise <72020169+iluise@users.noreply.github.com>
* Align usage of stream configs in model with dict semantics.

* parse stream configs into dictconfig instead of list

* Align data sampling to dict semantics, wrap self.streams into self.streams_datasets

* change list to dictconfig for streams

* fixes

* ruffed

* fix backward compatibility.

* address comments

* linter

* Adjust incoming fresh code.

* fix unit tests, rephrase comment
* multiple ranks in evaluation

* shorter version

* shorter version

* Minor correction to ranks PR (#2420)

* Fix minor bug

* Minor correction

* Linting

---------

Co-authored-by: Savvas Melidonis <79579567+SavvasMel@users.noreply.github.com>
* remove dead code from train_logger

* fix plot_loss_per_run

* fix filter logic

* address comments

---------

Co-authored-by: Christian Lessig <christian.lessig@ecmwf.int>
* Changes to allow for score animations. Addition possibility for log-scale colorbar

* Linting

* Edit config files

* Change to score map function name, move score function to new utils file, generalize single_animation function

* Minor edits

* Linting

* Minor corrections to clarify the sa variable

---------

Co-authored-by: iluise <72020169+iluise@users.noreply.github.com>
Co-authored-by: iluise <72020169+iluise@users.noreply.github.com>
* Delete unnecessary code

* Linting
…text in legend entries (#2433)

* Made legend font size and columns configurable and removed redundant
string from plot legend entries and moved this to title

* Reverting unnecessary changes

* Put losses per run behind command line arg (typically not used
currently)
…data (#2422)

* Custom data reader for operational analysis that accounts for actual availability

* Reduce mem footprint during training; add DataReaderAnemoiOperan

* Config files

* Fixed corner case: sample 0 that has no precedessor

* Added additional check

* Move OperAn data reader to extras readers

* Cleaning up

* Remove incorrect general setting for base permuation

* Remove incorrect time_window_step settings

* Linting

* Improved encapsulation
@github-actions github-actions Bot added data Anything related to the datasets used in the project eval anything related to the model evaluation pipeline infra Issues related to infrastructure model Related to model training or definition (not generic infra) labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Anything related to the datasets used in the project eval anything related to the model evaluation pipeline infra Issues related to infrastructure model Related to model training or definition (not generic infra)

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

9 participants