Skip to content

Implement first prototype to be tested#2474

Open
sophie-xhonneux wants to merge 3 commits into
develop-sslfrom
sophiex/dev-ssl/fix-channel-ordering
Open

Implement first prototype to be tested#2474
sophie-xhonneux wants to merge 3 commits into
develop-sslfrom
sophiex/dev-ssl/fix-channel-ordering

Conversation

@sophie-xhonneux

Copy link
Copy Markdown
Contributor

Description

When switching between ERA5 and Operational analysis we can select the same channels but they may have a different ordering making it hard to re-use pretrained encoders...

Issue Number

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

self.validate(0, self.test_cfg, self.batch_size_test_per_gpu)
logger.info(f"Finished inference run with id: {cf.general.run_id}")

def _check_channel_order_consistency(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled in the data readers and not in the trainer. The channels are available there and we only need to ensure that there's a stable ordering when the channel data is passed to the model. See

self.source_idx = self.select_channels(ds, "source")
and the related lines below in the file.

@github-actions github-actions Bot added the model Related to model training or definition (not generic infra) label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model Related to model training or definition (not generic infra)

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants