[#1804] Re-implement pytorch profiler pr#2504
Open
florianscheidl wants to merge 64 commits into
Open
Conversation
…eatherGenerator into flo/revisit-profiler-pr
grassesi
requested changes
Jun 16, 2026
grassesi
left a comment
Contributor
There was a problem hiding this comment.
I have not run it yet, but I am pretty sure there are still some configuration issues. Please see the comments for more details. I am also happy to discuss the implementation details I suggested.
…eatherGenerator into flo/revisit-profiler-pr
…eatherGenerator into flo/revisit-profiler-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #1804 was reverted, we slightly rewrote the profiler PR, which should avoid the issue with the profiling config.
✅ Important: wait for #2310 (review) to be merged first.
Issue Number
Fixes #1804
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60