Skip to content

multi_stream_data_sampler: Select existing filename from multiple options#2525

Merged
clessig merged 3 commits into
ecmwf:developfrom
jpolz:jpolz/develop/2524-choose-existing-filename
Jun 22, 2026
Merged

multi_stream_data_sampler: Select existing filename from multiple options#2525
clessig merged 3 commits into
ecmwf:developfrom
jpolz:jpolz/develop/2524-choose-existing-filename

Conversation

@jpolz

@jpolz jpolz commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

resolves blind choice of filename in multi_stream_data_sampler which can fail if first searched location is nonexistent

Issue Number

Closes #2524

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@github-actions github-actions Bot added the bug Something isn't working label Jun 21, 2026
@clessig clessig marked this pull request as ready for review June 22, 2026 07:10
@clessig clessig merged commit 2317e19 into ecmwf:develop Jun 22, 2026
2 of 3 checks passed
@jpolz jpolz deleted the jpolz/develop/2524-choose-existing-filename branch June 22, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

multi_stream_data_sampler sometimes blindly chooses filename even if nonexistent

2 participants