Feature/remove compiler workarounds#93
Merged
Merged
Conversation
wdeconinck
force-pushed
the
feature/remove_compiler_workarounds
branch
from
2aae5cb to
d28f00e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #93 +/- ##
========================================
Coverage 51.07% 51.07%
========================================
Files 58 58
Lines 4854 4854
Branches 453 453
========================================
Hits 2479 2479
Misses 2375 2375 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes workarounds for old compiler bugs (specifically for PGI/NVHPC and XL Fortran), and simplifies the code by eliminating related macros and conditional logic. All code now consistently uses the standard
c_ptr()method and direct Fortran allocation syntax for character variables, improving maintainability and clarity.The most important changes are:
Removal of compiler bug workarounds:
PGIBUG_ATLAS_197workaround for PGI/NVHPC compilers, including conditional use ofCPTR_PGIBUG_A/Band related preprocessor logic in both the CMake configuration and Fortran header/template files.FCKIT_ALLOCATE_CHARACTERand the associated XL Fortran bug logic, replacing all usages with direct Fortran allocation usingcharacter(len=...,kind=c_char).Code simplification and modernization:
c_ptr()member function directly instead of the workaround macros, ensuring consistent pointer handling throughout the codebase.These changes collectively modernize the codebase by removing legacy support for obsolete compiler bugs and making the code simpler and easier to maintain.